The issue is that shutdown_quit_notification blocks signals. In nodm_display_manager_wait functions there is waitpid call. This returns -1 if signal was received before session (dm->session.pid) was closed by systemctl. This is the happy scenario.

However, if session gets closed before signal was sent to the process. The waitpid returns dm->session.pid and the call to shutdown_quit_notification blocks SIGTERM. Due to this, catch_signals is never called and nodm proceeds to restarting display manager.

I have removed function shutdown_quit_notification altogether, as I don't see any need for it, since IMO there is no need to block these signals.

@slashblog: Thanks for working on issue #5.

However, your pull request is formalistically unclean. I'd be happy, if you are willing to...

• flatten your three commits into one
• use a proper commit msg
• add a "Fixes When systemd tries to kill nodm, nodm restarts itself instead #5." to your commit msg

To achieve this, you probably need to use git on the command line or some Git GUI. The Github WebUI stuff will be insufficient for handling this, I guess.

Are you willing to perform the requested changes? If not, please let me know. For an updated branch, please do a git push --force :. This will automatically update this PR.

THANKS!

@sunweaver Github allows you to:

• Auto squash commits upon merging
• Change the commit message before merging.

without having the original author (@slashblog) getting involved.

Just tested this on a Raspberry Pi running Raspbian Jessie and this PR solves the issue with nodm restarting itself when it is shutting down.

I tested this commit on my Manjaro system, running Openbox and systemd. No fix here sadly, still get the PID error and then nodm restarts itself.

This fixed the restart issue on my Intel Compute Stick running Ubuntu 16.04. Thanks @slashblog!

For the love of god, someone merge this already.

I am not active in nodm maintenance anymore. @sunweaver, can you look into this, or else add other people as maintainers?

Fix works for me